Supporting Run native behavior for Gradle #3282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitinp19
requested review from
agrasth,
bhanurp,
fluxxBot and
naveenku-jfrog
nitinp19
added
safe to test
nitinp19
force-pushed
the
runNativeSupport
branch
from
e8f36eb to
09a82df
Compare
nitinp19
added
safe to test
Contributor
nitinp19
force-pushed
the
runNativeSupport
branch
from
937061a to
c94626a
Compare
nitinp19
added
safe to test
nitinp19
force-pushed
the
runNativeSupport
branch
from
c94626a to
15005ef
Compare
nitinp19
added
safe to test
bhanurp
reviewed
Jan 6, 2026
Comment on lines
3
to
8
| /** | ||
| * Simple example class for the gradle test project. | ||
| * Note: We intentionally don't use JUnit here because dependency resolution | ||
| * may not work when the JFrog Gradle plugin configures the resolver to use | ||
| * the test Artifactory repository (which may not have JUnit cached). | ||
| */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** | |
| * Simple example class for the gradle test project. | |
| * Note: We intentionally don't use JUnit here because dependency resolution | |
| * may not work when the JFrog Gradle plugin configures the resolver to use | |
| * the test Artifactory repository (which may not have JUnit cached). | |
| */ | |
| // Simple example class for the gradle test project. | |
| // Note: We intentionally don't use JUnit here because dependency resolution | |
| // may not work when the JFrog Gradle plugin configures the resolver to use | |
| // the test Artifactory repository (which may not have JUnit cached). |
nitinp19
added
safe to test
naveenku-jfrog
approved these changes
Jan 6, 2026
| return cleanedArgs, serverDetails, nil | ||
| } | ||
|
|
||
| serverDetails, err := coreConfig.GetSpecificConfig(serverID, true, true) |
Collaborator
There was a problem hiding this comment.
This line should be before serverDetails, err := coreConfig.GetDefaultServerConf() condition. Extracting Default Server should be last option.
nitinp19
added
safe to test
nitinp19
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have enabled run native environmental variable which will let the user to run gradle native command. If the environmental variable is enabled, we will run the native flow.